Skip to content

Commit

Permalink
fix(web): compare previous semantic_version state in version refreshes
Browse files Browse the repository at this point in the history
(wouldn't update the version if you had a service-specific semantic_version)

fixes #279
  • Loading branch information
JosephKav committed Jul 1, 2023
1 parent 8ad06a2 commit 6548994
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion service/deployed_version/refresh.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (l *Lookup) Refresh(

// Whether overrides were provided or not, we can update the status if not.
overrides := headers != nil ||
semanticVersioning != nil ||
util.DefaultIfNil(l.Options.SemanticVersioning) != util.DefaultIfNil(lookup.Options.SemanticVersioning) ||
url != nil ||
json != nil ||
regex != nil
Expand Down
2 changes: 1 addition & 1 deletion service/latest_version/refresh.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ func (l *Lookup) Refresh(

// Whether overrides were provided or not, we can update the status if not.
overrides := require != nil ||
semanticVersioning != nil ||
util.DefaultIfNil(l.Options.SemanticVersioning) != util.DefaultIfNil(lookup.Options.SemanticVersioning) ||
url != nil ||
urlCommands != nil ||
usePreRelease != nil
Expand Down

0 comments on commit 6548994

Please sign in to comment.