Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broadcast stop early #128

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Broadcast stop early #128

merged 4 commits into from
Mar 3, 2025

Conversation

leo-lox
Copy link
Contributor

@leo-lox leo-lox commented Mar 3, 2025

  • adds timeouts to broadcast
  • adds percent consider broadcast done

=> considerDonePercent || timeout

@leo-lox leo-lox requested a review from frnandu March 3, 2025 10:13
@leo-lox leo-lox added the enhancement New feature or request label Mar 3, 2025
@leo-lox
Copy link
Contributor Author

leo-lox commented Mar 3, 2025

I moved the settings to ndkConfig, still possible to override when using the broadcast service directly.
I think this is more useful otherwise we need to pass the arg around in each use case

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.00%. Comparing base (78053fe) to head (d9a8642).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   72.87%   73.00%   +0.12%     
==========================================
  Files         106      106              
  Lines        3550     3563      +13     
==========================================
+ Hits         2587     2601      +14     
+ Misses        963      962       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leo-lox leo-lox merged commit 04e29d4 into master Mar 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants