Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relay/graphql-naming: Relay no longer enforces fragment name with *_<propName> #107

Open
mrtnzlml opened this issue Dec 4, 2020 · 1 comment · Fixed by adeira/universe#1459
Open

relay/graphql-naming: Relay no longer enforces fragment name with *_<propName> #107

mrtnzlml opened this issue Dec 4, 2020 · 1 comment · Fixed by adeira/universe#1459
Labels
help wanted

Comments

@mrtnzlml
Copy link

mrtnzlml commented Dec 4, 2020

See: facebook/relay@ff1c10b

There is still some enforcement. For example, the module name still has to be included. But the property name is no longer required in the fragment name which makes this line a bit obsolete:

eslint-plugin-relay/src/rule-graphql-naming.js

Line 74 in 130005b

'Container fragment names must be `<ModuleName>_<propName>`. ' +

Thanks for having a look! 😊
mrtnzlml added a commit to adeira/universe that referenced this issue Dec 4, 2020
@mrtnzlml
Eslint config: disable 'relay/graphql-naming' rule
9e4b446 
This rule is no longer accurate, see: facebook/relay@ff1c10b

We might (partially) revert this commit after this PR gets resolved: relayjs/eslint-plugin-relay#107
@mrtnzlml mrtnzlml mentioned this issue Dec 4, 2020
Merged
@sibelius
Copy link

sibelius commented Dec 4, 2020

I'd like to enforce this using a eslint rule, as simplify a lot

kodiakhq bot pushed a commit to adeira/universe that referenced this issue Dec 4, 2020
@mrtnzlml @kodiakhq
Eslint config: disable 'relay/graphql-naming' rule
10fdc0c 
This rule is no longer accurate, see: facebook/relay@ff1c10b

We might (partially) revert this commit after this PR gets resolved: relayjs/eslint-plugin-relay#107
adeira-github-bot pushed a commit to adeira/eslint-config-adeira that referenced this issue Dec 4, 2020
@mrtnzlml @adeira-github-bot
Eslint config: disable 'relay/graphql-naming' rule
6ac3e01 
This rule is no longer accurate, see: facebook/relay@ff1c10b

We might (partially) revert this commit after this PR gets resolved: relayjs/eslint-plugin-relay#107

adeira-source-id: 10fdc0cc30e9e75b24cecc48e87a03b8f0e824ab
adeira-github-bot pushed a commit to adeira/ya-comiste that referenced this issue Dec 8, 2020
@mrtnzlml @adeira-github-bot
Eslint config: disable 'relay/graphql-naming' rule
564dde2 
This rule is no longer accurate, see: facebook/relay@ff1c10b

We might (partially) revert this commit after this PR gets resolved: relayjs/eslint-plugin-relay#107

adeira-source-id: 10fdc0cc30e9e75b24cecc48e87a03b8f0e824ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eslint config: disable 'relay/graphql-naming' rule adeira/universe
3 participants
@alunyov @mrtnzlml @sibelius