-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove duplicated_ok #109
remove duplicated_ok #109
Conversation
Codecov Report
@@ Coverage Diff @@
## master #109 +/- ##
===========================================
+ Coverage 43.96% 83.24% +39.28%
===========================================
Files 43 43
Lines 2311 2310 -1
===========================================
+ Hits 1016 1923 +907
+ Misses 1295 387 -908
Continue to review full report at Codecov.
|
32c0fbf
to
390ed15
Compare
390ed15
to
16ab19f
Compare
Please review this PR first (fixed library versions in this PR) @keigohtr |
@@ -8,7 +8,7 @@ PyYAML>=3.12 # MIT | |||
SQLAlchemy>=1.2.7 # MIT | |||
PyMySQL>=0.8.0 # MIT | |||
flask-sqlalchemy>=2.3.2 # BSD | |||
kubernetes>=v8.0.0 # Apache-2.0 | |||
kubernetes>=v8.0.0,<10.0.0 # Apache-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is from this issue: kubernetes-client/python#866
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is this PR for?
remove
duplicated_ok
because I forgot doing so in #103This PR includes
What type of PR is it?
fix
What is the issue?
N/A
How should this be tested?
python -m unittest test/apis/test_api_evaluation.py