test: test new & legacy proxy (#16)

CHANGELOG.md

@@ -3,6 +3,7 @@
 ## 1.4.0
 
 * test: use full Symfony framework-bundle for testing
+* test: test new & legacy proxy
 
 ## 1.3.2
 

composer.json

@@ -22,16 +22,14 @@
     ],
     "require": {
         "doctrine/orm": "^2.16 || ^3.0",
-        "doctrine/persistence": "^3.1",
         "rekalogika/direct-property-access": "^1.1.2 || ^1.2",
         "symfony/config": "^6.0 || ^7.0",
         "symfony/dependency-injection": "^6.0 || ^7.0",
         "symfony/http-kernel": "^6.0 || ^7.0"
     },
     "require-dev": {
         "doctrine/collections": "^2.2",
-        "doctrine/doctrine-bundle": "^2.13",
-        "doctrine/doctrine-fixtures-bundle": "^3.6",
+        "doctrine/doctrine-bundle": "^2.0",
         "phpstan/phpstan": "^1.12",
         "phpunit/phpunit": "^10.5",
         "psalm/plugin-phpunit": "^0.19.0",

tests/config/packages/doctrine.yaml

@@ -6,13 +6,13 @@ doctrine:
         use_savepoints: true
 
     orm:
-        auto_generate_proxy_classes: true
-        naming_strategy: doctrine.orm.naming_strategy.underscore_number_aware
-        auto_mapping: true
-        enable_lazy_ghost_objects: true
-        report_fields_where_declared: true
-        controller_resolver:
-            auto_mapping: false
+        # auto_generate_proxy_classes: true
+        # naming_strategy: doctrine.orm.naming_strategy.underscore_number_aware
+        # auto_mapping: true
+        # enable_lazy_ghost_objects: true
+        # report_fields_where_declared: true
+        # controller_resolver:
+        #     auto_mapping: false
         mappings:
             Entity:
                 is_bundle: false

tests/src/Tests/DoctrineTest.php

@@ -90,13 +90,16 @@ public function testProxy(): void
         $this->assertInstanceOf(Proxy::class, $post);
         $this->assertFalse($post->__isInitialized());
 
-        // should be true. see https://github.com/doctrine/orm/pull/11606
-        // remove this when upstream fixes the problem
-        $post->getImage();
-        $this->assertFalse($post->__isInitialized());
+        if (!\property_exists($post, '__initializer__')) {
+            // lazy ghost proxy.
+            // should be true. see https://github.com/doctrine/orm/pull/11606
+            // remove this when upstream fixes the problem
+            $post->getImage();
+            $this->assertFalse($post->__isInitialized());
 
-        $post->getTitle();
-        $this->assertTrue($post->__isInitialized());
+            $post->getTitle();
+            $this->assertTrue($post->__isInitialized());
+        }
 
         $this->assertEquals('someImage', $post->getImage());
     }
@@ -117,6 +120,8 @@ public function testUninitializedProxyFlush(): void
         $this->assertInstanceOf(Post::class, $post);
         $this->assertInstanceOf(Proxy::class, $post);
         $this->assertFalse($post->__isInitialized());
+
+        // this flush should not remove the image
         $this->entityManager->flush();
 
         // clear
@@ -127,16 +132,19 @@ public function testUninitializedProxyFlush(): void
         $this->assertInstanceOf(Post::class, $post);
         $this->assertInstanceOf(Proxy::class, $post);
         $this->assertFalse($post->__isInitialized());
-        $this->entityManager->flush();
 
-        // should be true. see https://github.com/doctrine/orm/pull/11606
-        // remove this when upstream fixes the problem
-        $post->getImage();
-        $this->assertFalse($post->__isInitialized());
+        if (!\property_exists($post, '__initializer__')) {
+            // lazy ghost proxy.
+            // should be true. see https://github.com/doctrine/orm/pull/11606
+            // remove this when upstream fixes the problem
+            $post->getImage();
+            $this->assertFalse($post->__isInitialized());
 
-        $post->getTitle();
-        $this->assertTrue($post->__isInitialized());
+            $post->getTitle();
+            $this->assertTrue($post->__isInitialized());
+        }
 
+        // make sure the flush did not remove the image
         $this->assertEquals('someImage', $post->getImage());
     }
 }