minify-javascript-script: remove trailing semicolon

rehypejs · Nov 17, 2018 · e8cacd3 · e8cacd3
1 parent bda84c4
commit e8cacd3
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/packages/rehype-minify-javascript-script/index.js b/packages/rehype-minify-javascript-script/index.js
@@ -28,9 +28,15 @@ function transform(tree) {
 }
 
 function visitor(node) {
+  var val
   if (js(node) && !has(node, 'src')) {
     try {
-      fromString(node, Uglify.minify(toString(node)).code)
+      val = Uglify.minify(toString(node)).code
+      /* istanbul ignore else - not used, but just to be sure there’s an if */
+      if (val.charAt(val.length - 1) === ';') {
+        val = val.slice(0, -1)
+      }
+      fromString(node, val)
     } catch (error) {}
   }
 }
diff --git a/packages/rehype-minify-javascript-script/readme.md b/packages/rehype-minify-javascript-script/readme.md
@@ -24,7 +24,7 @@ npm install rehype-minify-javascript-script
 ##### Out
 
 ```html
-<script>var name="World";console.log("Hello, "+name+"!");</script>
+<script>var name="World";console.log("Hello, "+name+"!")</script>
 ```
 
 ## License

diff --git a/packages/rehype-minify-javascript-script/test.js b/packages/rehype-minify-javascript-script/test.js
@@ -14,7 +14,7 @@ test('rehype-minify-javascript-script', function(t) {
       .runSync(
         h('script', 'var name = "World";\nconsole.log("Hello, " + name + "!");')
       ),
-    h('script', 'var name="World";console.log("Hello, "+name+"!");')
+    h('script', 'var name="World";console.log("Hello, "+name+"!")')
   )
 
   t.deepEqual(
@@ -26,7 +26,7 @@ test('rehype-minify-javascript-script', function(t) {
           '(function () {var name = "World";\nconsole.log("Hello, " + name + "!");})()'
         )
       ),
-    h('script', 'console.log("Hello, World!");')
+    h('script', 'console.log("Hello, World!")')
   )
 
   t.deepEqual(