Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added codesign and resources #1069

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added codesign and resources #1069

wants to merge 3 commits into from

Conversation

stamepicmorg
Copy link
Contributor

@stamepicmorg stamepicmorg commented Dec 15, 2024


Caution

This is infrastructure update! NO code and NO bugfixes was implemented at ReHLDS at this PR.


Also, I know that we have .rc files that are used to create binaries.

The problem is that we have not yet fully decided how their future will develop from a development point of view. Also, now there are only 2 .rc files that are built into hlds.exe and hltv.exe. All other dlls are built naked, which excites antiviruses.

For now, I have chosen to use rcedit, written by the Electron project, which can successfully read and edit resources in compiled files. Which is what I am actually doing.

For now, I suggest leaving it as is. To launch the mechanism. And optimize it in subsequent iterations of development, to move the progress forward a little.

@stamepicmorg stamepicmorg added Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 👀 needs review Requires code or changes review. Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Type: ⚙️ infrastructure Tasks for maintaining or improving system infrastructure. Engine: ⚙️ Independent Case do not refer to any Engine. OS: 💻 Independent Case do not refer to any OS. labels Dec 15, 2024
@stamepicmorg stamepicmorg self-assigned this Dec 15, 2024
@stamepicmorg stamepicmorg marked this pull request as draft December 15, 2024 18:26
Copy link
Member

@SergeyShorokhov SergeyShorokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this functionality!

I need some time (I will gradually review this PR ) to look at this PR in detail.
You can immediately see the violation of the declarative component of the .yml file.

.github/workflows/build.yml Show resolved Hide resolved
@stamepicmorg
Copy link
Contributor Author

stamepicmorg commented Dec 16, 2024

Tonight I will update PR. Do not merge it yet please. Updated a0c03e9

Tip

We collectively came to the conclusion that signing each file inside the archive with .asc files is a bit redundant. For now, we'll just leave the signatures of the final archive and the native Windows ones.

@stamepicmorg stamepicmorg marked this pull request as ready for review December 19, 2024 19:56
@stamepicmorg stamepicmorg requested review from SergeyShorokhov and s1lentq and removed request for s1lentq and SergeyShorokhov December 19, 2024 19:57
@SergeyShorokhov SergeyShorokhov requested review from s1lentq and removed request for s1lentq December 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: 🟡 medium Task of medium difficulty requiring moderate effort. Engine: ⚙️ Independent Case do not refer to any Engine. OS: 💻 Independent Case do not refer to any OS. Priority: ⚠️ medium Medium priority tasks that should be addressed soon. Status: 👀 needs review Requires code or changes review. Type: ⚙️ infrastructure Tasks for maintaining or improving system infrastructure.
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants