Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group module #154

Merged
merged 136 commits into from
Jan 29, 2021
Merged
Show file tree
Hide file tree
Changes from 131 commits
Commits
Show all changes
136 commits
Select commit Hold shift + click to select a range
94b6d0a
Add group module and updated proto
blushi Nov 5, 2020
88219db
Delete unrelevant files
blushi Nov 5, 2020
1ea581c
WIP on upgrade to stargate
blushi Nov 5, 2020
e0983d1
Add TODO
blushi Nov 5, 2020
5d4b17d
Merge branch 'master' into marie/136-x-group
blushi Nov 6, 2020
46302c8
Fix proto-gen
blushi Nov 6, 2020
ac06ce7
Fix group AppModule and AppModuleBasic
blushi Nov 6, 2020
b83faeb
More migration in x/group
blushi Nov 6, 2020
e63f712
Fix lint
blushi Nov 6, 2020
4629fb1
More lint fix
blushi Nov 6, 2020
61558c3
Rename GroupID
blushi Nov 6, 2020
e8578c4
Merge branch 'master' into marie/136-x-group
blushi Nov 6, 2020
179d5a3
Fix TestGroupMetadataValidation and add UnpackInterfaces
blushi Nov 6, 2020
1b1d694
Merge branch 'master' into marie/136-x-group
blushi Nov 12, 2020
7c48dfb
Refacto to use Msg services
blushi Nov 12, 2020
4acfd5a
Move module impl to x/group/module and remove amino
blushi Nov 12, 2020
5f66c4f
Fix build
blushi Nov 12, 2020
55b0df8
Fix lint
blushi Nov 12, 2020
6338a52
Clean up testutil
blushi Nov 12, 2020
63227df
Add Proposal and CreateProposal rpc, use Any for msgs in it
blushi Nov 13, 2020
41612ce
Fix lint
blushi Nov 13, 2020
4aba3fc
Fix initParamsKeeper
blushi Nov 13, 2020
5aae182
Merge branch 'master' into marie/136-x-group
blushi Nov 13, 2020
742d2b9
Comment group ref in app
blushi Nov 18, 2020
a9d5fcf
Add comments in proto
blushi Nov 18, 2020
548340f
Merge branch 'master' into marie/136-x-group
blushi Nov 18, 2020
3bba95a
gen proto
blushi Nov 18, 2020
f777129
wip on tests
blushi Nov 19, 2020
1af002b
Setup test suite
blushi Nov 19, 2020
4718f17
Rm keeper_test
blushi Nov 19, 2020
1212b8d
Rm testsupport.go
blushi Nov 19, 2020
97cf006
Move old hander tests to testsuite and use msgClient in tests
blushi Nov 19, 2020
4887476
Use BinaryMarshaler in ORM to unpack Any's
blushi Nov 20, 2020
dc61a9b
Fix exec proposal tests
blushi Nov 20, 2020
a62bdb0
Fix group tests
blushi Nov 25, 2020
95a81c8
Add proposal executor tests
blushi Nov 25, 2020
070c047
Update ORM tests
blushi Nov 25, 2020
db313ee
Wire up group module to regen app
blushi Nov 25, 2020
24fce14
Merge branch 'master' into marie/136-x-group
blushi Nov 25, 2020
09216b7
Fix lint
blushi Nov 25, 2020
83ad845
Fix proto lint
blushi Nov 25, 2020
8321ff0
Renaming
blushi Nov 25, 2020
f834ea5
Update ORM
blushi Nov 26, 2020
ce52870
Merge branch 'master' into marie/136-x-group
blushi Nov 26, 2020
e80c00c
Remove errors pkg
blushi Nov 26, 2020
67ede52
Merge branch 'marie/136-x-group' of github.com:regen-network/regen-le…
blushi Nov 26, 2020
1e1e4d1
Improve proposal doc
blushi Nov 26, 2020
2693e75
Fix events types
blushi Nov 26, 2020
f523044
Update comment
blushi Nov 26, 2020
75194ac
Clean up
blushi Nov 26, 2020
01fa2a1
Use GroupId
blushi Nov 26, 2020
2058ef0
Use ProposalId
blushi Nov 26, 2020
3c620a0
Update conditions.go
blushi Nov 26, 2020
a2a508f
Rename to GetGroupMembers
blushi Nov 26, 2020
814f33d
Add assertCommentSize
blushi Nov 26, 2020
1563e6d
Update x/group/server/keeper.go
blushi Nov 26, 2020
171c485
Update x/group/server/keeper.go
blushi Nov 26, 2020
b11796a
Rename result enum value
blushi Nov 27, 2020
33040fe
Add doc
blushi Nov 27, 2020
307191c
Add doc
blushi Nov 27, 2020
3fb86a6
Merge branch 'marie/136-x-group' of github.com:regen-network/regen-le…
blushi Nov 27, 2020
d7a94a6
Use apd.Decimal instead of sdk.Dec
blushi Dec 3, 2020
47ee8ae
Rename to GroupInfo and GroupAcountInfo
blushi Dec 3, 2020
47040d8
Move group/types to group
blushi Dec 4, 2020
ecbac2b
Remove tmp query.proto
blushi Dec 4, 2020
29ab424
Move Keeper methods to serverImpl
blushi Dec 4, 2020
cb440a0
Add Query service proto def
blushi Dec 4, 2020
9083119
Add first impl of query service
blushi Dec 8, 2020
ff624f7
Finish up query service and rm keeper
blushi Dec 9, 2020
f9eae0d
Lint
blushi Dec 9, 2020
96824bc
Rename GroupID to ID
blushi Dec 9, 2020
fa85eec
Support Key page request with index.Get
blushi Dec 15, 2020
fd44c16
Merge branch 'master' into marie/136-x-group
blushi Dec 17, 2020
0b04ac2
Lint
blushi Dec 17, 2020
985b4c3
Format
blushi Dec 17, 2020
184d271
Use bech32 addresses
blushi Dec 18, 2020
113af10
Lint
blushi Dec 18, 2020
cb413b7
Update group events
blushi Jan 6, 2021
ea502f8
Merge branch 'master' into marie/136-x-group
blushi Jan 6, 2021
30dd644
Refactor group module to work with new proto codegen
blushi Jan 8, 2021
b9fb3bc
Lint
blushi Jan 8, 2021
75541a5
Update protocgen script
blushi Jan 8, 2021
311840a
Update proto/regen/group/v1alpha1/genesis.proto
blushi Jan 20, 2021
2671823
Update proto/regen/group/v1alpha1/query.proto
blushi Jan 20, 2021
e5d58a7
Update proto/regen/group/v1alpha1/events.proto
blushi Jan 20, 2021
6addb18
Update x/group/README.md
blushi Jan 20, 2021
2f6e6c6
Update testutil/testdata/tx.proto
blushi Jan 20, 2021
c30ff36
Address review comments
blushi Jan 20, 2021
0716554
Update README.md
blushi Jan 20, 2021
7077e80
Merge branch 'master' into marie/136-x-group
blushi Jan 20, 2021
9a4b3fa
Reference issues in todos
blushi Jan 22, 2021
ad93c20
Rename member's weight variables
blushi Jan 22, 2021
f2c80a1
Update x/group/server/msg_server.go
blushi Jan 22, 2021
0c82a0a
Update x/group/README.md
blushi Jan 22, 2021
3dee6b5
Update AccAddresses ValidateBasic
blushi Jan 22, 2021
aba6b2e
Remove useless address var
blushi Jan 22, 2021
438e128
Reference event issue
blushi Jan 22, 2021
501b461
Add comment in Vote
blushi Jan 22, 2021
ab35cd4
Update x/group/README.md
blushi Jan 22, 2021
1783ffd
Update x/group/README.md
blushi Jan 22, 2021
72608bf
Add GetPaginated to orm Index
blushi Jan 22, 2021
c1a8cb9
Merge branch 'marie/136-x-group' of github.com:regen-network/regen-le…
blushi Jan 22, 2021
c14aea4
Rename var in orm/iterator
blushi Jan 22, 2021
2740733
Replace comment with metadata
blushi Jan 22, 2021
8884926
More renaming
blushi Jan 22, 2021
e89d701
Support only one voter per Vote request
blushi Jan 22, 2021
29509d7
Use fixed MaxMetadataLength
blushi Jan 26, 2021
1520eae
Merge branch 'marie/136-group-exp' into marie/136-x-group
blushi Jan 26, 2021
14d5e5b
Migrate group module to use ADR 033 and update GroupMember type
blushi Jan 26, 2021
51559ee
Link
blushi Jan 26, 2021
81a124f
Reorder members in test to compare
blushi Jan 27, 2021
cb3d217
Rename perm to conditionFormat
blushi Jan 27, 2021
a5a41a0
Update x/group/conditions.go
blushi Jan 27, 2021
5cfdc50
Add Paginate doc
blushi Jan 27, 2021
311cbbd
Update orm/iterator.go
blushi Jan 27, 2021
6404a42
Update doc
blushi Jan 27, 2021
0d359dc
Add more docs
blushi Jan 27, 2021
392966a
More docs
blushi Jan 27, 2021
42ee1f0
Add more tests for GetPaginated
blushi Jan 27, 2021
fae37ab
Add err check in assertion
blushi Jan 27, 2021
79ad498
Always handle errors in Paginate loop
blushi Jan 27, 2021
1588152
Add more comments to Paginate
blushi Jan 27, 2021
2a89d1f
Move destRef.Set to end of loop
blushi Jan 27, 2021
293f3ae
Add more tests cases for Paginate
blushi Jan 27, 2021
f26deee
Merge branch 'master' into marie/136-x-group
anilcse Jan 27, 2021
ea63321
Update proto/regen/group/v1alpha1/tx.proto
blushi Jan 27, 2021
04fdbcb
Update proto/regen/group/v1alpha1/types.proto
blushi Jan 27, 2021
c19d8b0
Refactor Fixture (#228)
aaronc Jan 28, 2021
7b2cfdd
Address some of review comments
blushi Jan 28, 2021
6f7f619
Merge branch 'marie/136-x-group' of github.com:regen-network/regen-le…
blushi Jan 28, 2021
162c271
Address comments and add more docs
blushi Jan 29, 2021
ea9ba41
Update x/group/server/msg_server.go
blushi Jan 29, 2021
4f92bcb
Update x/group/server/msg_server.go
blushi Jan 29, 2021
fb5b37e
Update comment
blushi Jan 29, 2021
c938549
Merge branch 'master' into marie/136-x-group
blushi Jan 29, 2021
cce7ae8
Update proto/regen/group/v1alpha1/query.proto
robert-zaremba Jan 29, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -181,4 +181,9 @@ tags
.idea

build/

# OS
.DS_Store

/protoc-gen-go-cosmos2/protoc-gen-go-cosmos2
/tools-stamp
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -321,15 +321,20 @@ proto-check-breaking-docker:
@$(DOCKER_BUF) check breaking --against-input $(HTTPS_GIT)#branch=master

GOGO_PROTO_URL = https://raw.githubusercontent.com/regen-network/protobuf/cosmos
REGEN_COSMOS_PROTO_URL = https://raw.githubusercontent.com/regen-network/cosmos-proto/master
COSMOS_PROTO_URL = https://raw.githubusercontent.com/cosmos/cosmos-sdk/master/proto/cosmos

GOGO_PROTO_TYPES = third_party/proto/gogoproto
REGEN_COSMOS_PROTO_TYPES = third_party/proto/cosmos_proto
COSMOS_PROTO_TYPES = third_party/proto/cosmos

proto-update-deps:
@mkdir -p $(GOGO_PROTO_TYPES)
@curl -sSL $(GOGO_PROTO_URL)/gogoproto/gogo.proto > $(GOGO_PROTO_TYPES)/gogo.proto

@mkdir -p $(REGEN_COSMOS_PROTO_TYPES)
@curl -sSL $(REGEN_COSMOS_PROTO_URL)/cosmos.proto > $(REGEN_COSMOS_PROTO_TYPES)/cosmos.proto

@mkdir -p $(COSMOS_PROTO_TYPES)/base/query/v1beta1/
@curl -sSL $(COSMOS_PROTO_URL)/base/query/v1beta1/pagination.proto > $(COSMOS_PROTO_TYPES)/base/query/v1beta1/pagination.proto

Expand Down
7 changes: 5 additions & 2 deletions app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,11 @@ import (
"github.com/CosmWasm/wasmd/x/wasm"
wasmclient "github.com/CosmWasm/wasmd/x/wasm/client"

newmodule "github.com/regen-network/regen-ledger/types/module"
moduletypes "github.com/regen-network/regen-ledger/types/module"
servermodule "github.com/regen-network/regen-ledger/types/module/server"
data "github.com/regen-network/regen-ledger/x/data/module"
ecocredit "github.com/regen-network/regen-ledger/x/ecocredit/module"
group "github.com/regen-network/regen-ledger/x/group/module"
)

const (
Expand Down Expand Up @@ -130,11 +131,13 @@ var (
wasm.AppModuleBasic{},
ecocredit.Module{},
data.Module{},
group.Module{},
)

NewModules = []newmodule.Module{
NewModules = []moduletypes.Module{
ecocredit.Module{},
data.Module{},
group.Module{},
}

// module account permissions
Expand Down
2 changes: 2 additions & 0 deletions buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,11 @@ lint:
ignore:
- cosmos
- gogoproto
- cosmos_proto
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the linter ignoring all proto files in regen-ledger? Why?

Copy link
Member

@aaronc aaronc Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it isn't just 3rd party

breaking:
use:
- FILE
ignore:
- cosmos
- gogoproto
- cosmos_proto
Loading