feat(x/ecocredit): add update basket curator

[aleem1314]

Description

Closes: #1457

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #1484 (4cc47f5) into main (cb09a89) will increase coverage by 0.06%.
The diff coverage is 86.25%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1484      +/-   ##
==========================================
+ Coverage   78.25%   78.32%   +0.06%     
==========================================
  Files         248      250       +2     
  Lines       18650    18810     +160     
==========================================
+ Hits        14594    14732     +138     
- Misses       3204     3220      +16     
- Partials      852      858       +6     

Impacted Files	Coverage Δ
x/ecocredit/client/tx.go	0.00% <0.00%> (ø)
x/ecocredit/basket/keeper/msg_update_curator.go	55.17% <55.17%> (ø)
x/ecocredit/basket/client/tx.go	70.85% <81.25%> (+1.54%)	⬆️
x/ecocredit/basket/types/v1/msg_update_curator.go	90.47% <90.47%> (ø)
x/ecocredit/basket/types/v1/codec.go	100.00% <100.00%> (ø)
x/ecocredit/client/testsuite/tx_basket.go	100.00% <100.00%> (ø)

[technicallyty]

LGTM! just a few comments

[technicallyty]

recently discovered this issue cosmos/cosmos-sdk#12332

i dont think its really necessary to change the tests here in this PR, unless you want to, but just adding a note here that we probably want to switch to gotest.tools/v3/assert for future tests. tracking: #1487

[ryanchristo]

Oof. I do like the methods available in require but makes sense. There is a command line tool to automate the migration so we can handle all at once in a separate pull request. Also see #1487 (comment)

[ryanchristo]

Oof. I do like the methods available in require but makes sense. There is a command line tool to automate the migration so we can handle all at once in a separate pull request. Also see #1487 (comment)

[ryanchristo]

tACK