feat(x/group): remove regen group module #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1258 +/- ##
==========================================
- Coverage 80.11% 77.25% -2.86%
==========================================
Files 235 212 -23
Lines 21558 16024 -5534
==========================================
- Hits 17271 12380 -4891
+ Misses 2996 2655 -341
+ Partials 1291 989 -302
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ryanchristo
approved these changes
Jul 18, 2022
app/experimental_appconfig.go
Outdated
Comment on lines
101
to
103
| // BEGIN HACK: this is a total, ugly hack until x/auth & x/bank supports ADR 033 or we have a suitable alternative | ||
|
|
||
| groupModule := group.Module{AccountKeeper: app.AccountKeeper, BankKeeper: app.BankKeeper} | ||
| // use a separate newModules from the global NewModules here because we need to pass state into the group module | ||
| newModules := []moduletypes.Module{ | ||
| groupModule, | ||
| } | ||
| err := newModuleManager.RegisterModules(newModules) | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| // END HACK |
There was a problem hiding this comment.
We should remove the BEGIN HACK and END HACK comments here as well.
|
Can you also add a changelog entry? 🙏 |
ryanchristo
changed the title
ryanchristo
reviewed
Jul 18, 2022
ryanchristo
reviewed
Jul 18, 2022
technicallyty
approved these changes
Jul 19, 2022
|
why did we keep x/group/spec? |
Hambach is using the old version of the group module and so the docs should still be accessible. #1258 (comment) https://docs.regen.network/modules/group/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ref: #667
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change