Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added type hints for the public functions #153

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Added type hints for the public functions #153

merged 1 commit into from
Oct 9, 2023
+6 −6

Conversation

regebro
Copy link
Owner

@regebro regebro commented Oct 9, 2023

No description provided.

agronholm
agronholm previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some return types should probably be changed.

tzlocal/win32.py Outdated Show resolved Hide resolved
tzlocal/win32.py Outdated Show resolved Hide resolved
@regebro regebro force-pushed the lregebro-type-hints branch from 0e7ae88 to cbf0496 Compare October 9, 2023 13:00
@regebro regebro force-pushed the lregebro-type-hints branch from cbf0496 to 660c499 Compare October 9, 2023 13:03
@agronholm agronholm merged commit 5e61a87 into master Oct 9, 2023
16 checks passed
@agronholm agronholm deleted the lregebro-type-hints branch October 9, 2023 19:14
@agronholm
Copy link
Collaborator

agronholm commented Oct 9, 2023 •
edited
Loading

Awesome! What's now left is to mark the project as typed by adding the py.typed marker (plus the Typing :: Typed classifier, although that makes no practical difference).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agronholm agronholm agronholm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regebro @agronholm