Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Lois Dites broken on Legifrance #129

Open
boogheta opened this issue Sep 22, 2020 · 6 comments
Open

Fix Lois Dites broken on Legifrance #129

boogheta opened this issue Sep 22, 2020 · 6 comments

Comments

@boogheta
Copy link
Contributor

No description provided.

@mdamien
Copy link
Member

mdamien commented Oct 1, 2020

Since it doesn't look like this feature is coming back on legifrance, we could archive the last JSON in the repo and use it instead

@boogheta
Copy link
Contributor Author

boogheta commented Oct 1, 2020

I understand they should add it somewhere in the opendata but yeah in the mean time archiving the json would make sense definitely !

@mdamien
Copy link
Member

mdamien commented Oct 1, 2020

Hop, I have implemented that: 0692ed8 and f9dae82

Looks like there's another problem, we use the JORFTEXTXXXX ID to match the text and it's name but we no longer have this ID in the URL

@mdamien
Copy link
Member

mdamien commented Oct 1, 2020

My bad, the JORFTEXT ID is there on the new urls, ex: https://www.legifrance.gouv.fr/jorf/id/JORFTEXT000042219373

@mdamien
Copy link
Member

mdamien commented Oct 29, 2020

We can say this bug is fixed I think, since the PR was merged

@mdamien mdamien closed this as completed Oct 29, 2020
@boogheta
Copy link
Contributor Author

Mmm no this was a temporary fix, but it froze the set, while lois dites are supposed to be included in the new legifrance as well and will still need to be handled

@boogheta boogheta reopened this Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants