Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict missing next step when possible #117

Open
boogheta opened this issue Dec 10, 2018 · 2 comments
Open

Predict missing next step when possible #117

boogheta opened this issue Dec 10, 2018 · 2 comments

Comments

@boogheta
Copy link
Contributor

boogheta commented Dec 10, 2018

Sometimes, AN/Senate publish a new adopted text but fail to announce the upcoming step, in those case our data remains stuck to the previous version without including the new text even though it is parsed properly.

For instance here and there : (but this might change further on)

The problem is caught there:

https://github.com/regardscitoyens/the-law-factory-parser/blob/master/tlfp/tools/update_procedure.py#L67-L74

But we might want to handle that upper in the chain, for instance after having merged AN & Senate's dossiers, although at this time we do not know for sure yet which steps are echec or not, so not sure...

cf #89

@mdamien
Copy link
Member

mdamien commented Dec 10, 2018

In the case of the PJLF 2019, I think it's because we remove the predicted hemicycle step in merge.py to keep only the commission step.

# Only keep first empty consecutive step as next one to come
if not dos.get('url_jo'):
if step.get('source_url'):
empty_last_step = False
elif empty_last_step:
break
else:
empty_last_step = True

A simple fix would be to keep the hemicycle step when merging for live texts even when there's a commission step.

@boogheta
Copy link
Contributor Author

or in this case to not keep commission steps as empty_last_step if the text is using the old_procedure ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants