Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRC32 bug fixed #6

Merged
merged 1 commit into from
Aug 10, 2014
Merged

CRC32 bug fixed #6

merged 1 commit into from
Aug 10, 2014

Conversation

CanoeFZH
Copy link

@CanoeFZH CanoeFZH commented Jul 8, 2014

Only the last three digits of the hash output of old version of CRC32 changes due to the unsigned char lookup table setting.

lrog added a commit that referenced this pull request Aug 10, 2014
CRC32 bug fixed -- changed form uchar to uint32 lookup table value type
@lrog lrog merged commit 7db82c2 into refresh-bio:master Aug 10, 2014
@lrog
Copy link
Collaborator

lrog commented Aug 10, 2014

Good finding, thanks a lot!

@CanoeFZH CanoeFZH deleted the crc32 branch December 12, 2014 13:09
@CanoeFZH CanoeFZH restored the crc32 branch August 5, 2015 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants