Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop ignoring some lint rules #4311

Merged
merged 6 commits into from
Nov 6, 2024
Merged

stop ignoring some lint rules #4311

merged 6 commits into from
Nov 6, 2024

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Nov 6, 2024

No description provided.

masenf
masenf approved these changes Nov 6, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm actually surprised we had so many useless f-strings here

@Lendemor
Copy link
Collaborator Author

Lendemor commented Nov 6, 2024

i'm actually surprised we had so many useless f-strings here

Yeah, I wonder why we ignored that rule in the first place, doesn't seems like it would change any behaviour in the code 🤔

@adhami3310 adhami3310 merged commit 4c0b491 into main Nov 6, 2024
34 checks passed
@adhami3310 adhami3310 deleted the lendemor/stop_ignoring_some_lint_rules branch November 6, 2024 21:32
benedikt-bartscher pushed a commit to benedikt-bartscher/reflex that referenced this pull request Nov 7, 2024
@Lendemor @benedikt-bartscher
stop ignoring some lint rules (reflex-dev#4311)
8c38f77 
* bump python packages version

* stop ignoring some lint rules that pass ruff check

* stop ignoring rule F541

* remove sneaky test file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhami3310 adhami3310 adhami3310 left review comments

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lendemor @masenf @adhami3310