only run macOS job on merge #4139
Merged
+73
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lendemor
changed the title
masenf
approved these changes
Oct 9, 2024
Yep, I first tried with adding some conditions and not duplicating the definition, but it was still creating the job and then we still had the delay in runner pickup. |
Kastier1
pushed a commit
that referenced
this pull request
Oct 23, 2024
* update workflow * skip more in unit tests * try something else to prevent adding macos job to pool * exclude too much * fix units-text with macOS excluded * also drop macOS job in integration tests * readd macos job separately to only run on merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are slow in being picked up by github runner and should be very similar to the ubuntu one.