Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'enter_key_submit=True' on 'rx.text_area' by disabling debounce if set #4084

Closed
wants to merge 1 commit into from

Conversation

TimChild
Copy link
Contributor

@TimChild TimChild commented Oct 7, 2024

All Submissions:

  • [x ] Have you followed the guidelines stated in CONTRIBUTING.md file?
  • [x ] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

New Feature Submission:

  • [x ] Does your submission pass the tests?
  • [x ] Have you linted your code locally prior to submission?

Changes To Core Features:

  • [x ] Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable? -- no
  • [x ] Have you successfully ran tests with your changes locally?

After these steps, you're ready to open a pull request.

b. Describe your changes.

Add additional constraint on whether to wrap rx.text_area in DebounceInput. Don't wrap if enter_key_submit is True.
Without this, the enter_key_submit behaviour is ignored.

Closes #4080

Note: If there is a way to do this without having to remove the DebounceInput, that would be even better.

@TimChild
Copy link
Contributor Author

TimChild commented Oct 7, 2024

@masenf -- I don't know why the bump to 0.6.1 was included in this PR...
Is there an easy way to remove that?

@masenf
Copy link
Collaborator

masenf commented Oct 7, 2024

Is there an easy way to remove that?

git fetch origin
git rebase -i origin/main

--> Remove the version bump commit, save, and exit the editor

git push myfork main --force

@masenf
Copy link
Collaborator

masenf commented Oct 9, 2024

I pushed an alternative fix for this in #4142. @TimChild can you try out my patch and see if it's working for your use case?

@masenf masenf closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enter_key_submit doesn't work for rx.text_area if value is set (works for rx.el.textarea).
3 participants