Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use is true for boolify #3946

Merged
merged 1 commit into from
Sep 18, 2024
Merged

use is true for boolify #3946

merged 1 commit into from
Sep 18, 2024

Conversation

adhami3310
Copy link
Member

No description provided.

Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding this to the integration test_var_operations.py might be helpful if this type of change doesn't trigger a test change, then we must not have good enough coverage

@adhami3310
Copy link
Member Author

I believe you meant test_vars.py (the unit one) and not test_var_operations.py (the integration one, that only tests the output).

But your assumption is correct, there is no tests that match with .bool().

@adhami3310 adhami3310 merged commit d81faf7 into main Sep 18, 2024
46 checks passed
masenf pushed a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants