ImmutableVar perf optimizations #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice trying it out |
|
Works well for me if I run it with REFLEX_COMPILE_PROCESSES=1, otherwise, I run into some problems, and compile hangs |
is this before, during, or after the compiling progress bar appears? i'm not reproducing the issue on my side |
masenf
force-pushed
the
masenf/var-perf
branch
from
62fd68f
to
58c7524
Compare
|
deadlocking issues fixed in #3835 |
masenf
force-pushed
the
masenf/var-perf
branch
from
58c7524
to
ecac015
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shave 30s off reflex-web compile time with the new ImmutableVar PR #3743
VarData.mergeyields no result