Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release actions #203

Merged
merged 10 commits into from
Oct 9, 2024
Merged

Update release actions #203

merged 10 commits into from
Oct 9, 2024

Conversation

bmaranville
Copy link
Member

Getting actions ready for publishing a wheel to pypi, and for building distributables for all platforms. Tested on a fork, all of the actions seem to be working.

@bmaranville
Copy link
Member Author

pre-commit.ci run

@bmaranville bmaranville mentioned this pull request Oct 9, 2024
@bmaranville
Copy link
Member Author

I'm realizing that the publish-pypi action won't work for pre-releases that well... it is looking for the latest release of bumps to install, while we want it to use the minimum required bumps version from pyproject.toml (which sometimes will be a pre-release)

I'm working on a fix now, using the builder script in refl1d/webview/build_client.py instead of specifying the steps for building in the action directly, because if we pip install from source, we'll get the correct version of bumps, and build_client will use that.

@bmaranville
Copy link
Member Author

I think I will merge this without review, because it's impossible to test its full functionality without merging it and attempting to publish a new pre-release to pypi.

@bmaranville bmaranville merged commit c0f848f into master Oct 9, 2024
9 checks passed
@glass-ships glass-ships deleted the update-release-actions branch November 15, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant