FIX: Change errors.py calc_errors() to produce a smooth magnetic profile #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the contours generated for magnetic profiles for the non-sliced samples are producing a step profile. Given the fact that we are already using smooth_profile() for non-magnetic profiles, we should change this to be consistent.
|
@bmaranville Could you review this and make sure you are happy? This was the change we talked about yesterday. |
bmaranville
reviewed
Jun 10, 2021
There was a problem hiding this comment.
I think that the microslabber is doing a "blend" operation on thetaM now, which is closer to what the Nevot-Croce approximation corresponds to - so there's no reason not to use the smooth profile representation (a long time ago there might have been an inconsistency in what was represented)
|
Yes, that makes sense, both why it is and why it should change. Feel free to pull. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the contours generated for magnetic profiles for the non-sliced samples are producing a step profile. Given the fact that we are already using smooth_profile() for non-magnetic profiles, we should change this to be consistent.