Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clean-issue-filters feature #2114

Merged
merged 8 commits into from
Jun 7, 2019

Conversation

notlmn
Copy link
Contributor

@notlmn notlmn commented Jun 3, 2019

Closes #2016.

Test

@notlmn
Copy link
Contributor Author

notlmn commented Jun 3, 2019

Also thought of adding support for repo deployment status, but that requires another API request (one to get latest commit, and one to get its deployment status). And targeting status dropdown is a bit of problem too.

source/libs/utils.ts Outdated Show resolved Hide resolved
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
source/features/clean-issue-filters.tsx Outdated Show resolved Hide resolved
source/features/clean-issue-filters.tsx Show resolved Hide resolved
source/features/clean-issue-filters.tsx Outdated Show resolved Hide resolved
source/features/clean-issue-filters.tsx Outdated Show resolved Hide resolved
source/features/clean-issue-filters.tsx Outdated Show resolved Hide resolved
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the feature to the readme and add yourself to CODEOWNERS?

  1. Zoom at 200% (or have a retina display)
  2. Reuse this format and its arrows (copy-paste them): https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png

Also it would be good to cache the result of this, per-repo, especially with #2109 coming :)

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

source/features/clean-issue-filters.tsx Outdated Show resolved Hide resolved
@notlmn
Copy link
Contributor Author

notlmn commented Jun 7, 2019

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

Took me a while to debug, but that's part of filter-pr-by-build-status. The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.


Also it would be good to cache the result of this, per-repo, especially with #2109 coming :)

Let's deal with that in a separate PR. Or will have to wait until #2109 is merged.

@fregante
Copy link
Member

fregante commented Jun 7, 2019

The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.

D’oh, I forgot about that

}
user(login: "${ownerName}") {
projects { totalCount }
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently even if I have a personal project, public, with an issue from the current repo inside, the dropdown is still empty for me.

I dropped this

@fregante fregante changed the title Cleanup issue and PR filters Add clean-issue-filters feature Jun 7, 2019
@fregante fregante merged commit f19e54b into refined-github:master Jun 7, 2019
@FloEdelmann
Copy link
Member

Thanks @notlmn! 😊

@fregante
Copy link
Member

fregante commented Jun 7, 2019

It does look much better now!

@notlmn notlmn deleted the clean-issue-filters branch June 7, 2019 10:20
@notlmn
Copy link
Contributor Author

notlmn commented Jun 7, 2019

If not impossible, it would be nice to also drop the Checks selector. Does the API include that?

Took me a while to debug, but that's part of filter-pr-by-build-status. The dropdown doesn't exist until that features adds it, maybe it's better to handle this in that feature.

Opened #2127 to track this.

@yakov116
Copy link
Member

@notlmn nothing major but

❌ clean-issue-filters
content.js:2111 TypeError: Cannot read property 'parentElement' of null
    at clean_issue_filters_init (content.js:6423)
    at async features_run (content.js:2106)

When a repo has not Issues or Pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Hide irrelevant issue/PR filters
5 participants