-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clean-issue-filters
feature
#2114
Conversation
Also thought of adding support for repo deployment status, but that requires another API request (one to get latest commit, and one to get its deployment status). And targeting status dropdown is a bit of problem too. |
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the feature to the readme and add yourself to CODEOWNERS?
- Zoom at 200% (or have a retina display)
- Reuse this format and its arrows (copy-paste them): https://user-images.githubusercontent.com/1402241/55069759-bceaf080-50bf-11e9-84d0-7707de2eb9e9.png
Also it would be good to cache the result of this, per-repo, especially with #2109 coming :)
If not impossible, it would be nice to also drop the Checks selector. Does the API include that?
Took me a while to debug, but that's part of
Let's deal with that in a separate PR. Or will have to wait until #2109 is merged. |
D’oh, I forgot about that |
} | ||
user(login: "${ownerName}") { | ||
projects { totalCount } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently even if I have a personal project, public, with an issue from the current repo inside, the dropdown is still empty for me.
I dropped this
Thanks @notlmn! 😊 |
It does look much better now! |
Opened #2127 to track this. |
@notlmn nothing major but
When a repo has not Issues or Pull requests |
Closes #2016.
Test