fix: #174 zero amount when pasting

[danielnordh]

This fixes #174 and shows the manual entry screen if a valid onchain address is pasted but amount is 0.
From the manual entry screen the user can add an amount and see the pasted address.

Summary by CodeRabbit

• Bug Fixes
  • Improved the send process so that if no amount is provided, users are now directed to manually enter payment details rather than moving forward to review. This change helps ensure a smoother and more intuitive payment workflow.

[coderabbitai]

Walkthrough

The pull request introduces a conditional branch in the SendScanAddressView for both the handleScan and pasteAddress functions. The new logic checks the viewModel.amountSat value: if it is zero, the view state is set to .manualEntry; otherwise, it remains at .reviewPayment. This adjustment ensures the user is routed correctly when no amount is specified during the scan QR process.

Changes

File(s)	Change Summary
LDKNodeMonday/.../SendScanAddressView.swift	Added a conditional check in handleScan and pasteAddress to set sendViewState to .manualEntry if amountSat equals 0, otherwise to .reviewPayment.

Sequence Diagram(s)

sequenceDiagram
  participant U as User
  participant V as SendScanAddressView
  participant VM as ViewModel
  
  U->>V: Initiate scan/paste action
  V->>VM: Check amountSat value
  alt amountSat equals 0
      VM->>V: Set sendViewState to .manualEntry
  else 
      VM->>V: Set sendViewState to .reviewPayment
  end

Loading

Assessment against linked issues

Objective	Addressed	Explanation
Ensure scan QR button process handles zero amount properly (#174)	✅

Poem

I'm a bunny with a code so light,
Hopping through logic in the night.
If amount is zero, manual entry leads the way,
Else review ensures payments don't stray.
Happy hops and codes anew – watch me play!
🐰💻
Cheers to changes that bring a brighter day!

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

LDKNodeMonday/View/Home/Send/SendScanAddressView.swift (2)

64-71: Remove redundant assignment in handleScan function.

The current implementation sets viewModel.sendViewState = .reviewPayment and then immediately follows with a conditional that either sets it to .manualEntry or .reviewPayment again. This initial assignment is unnecessary and can be removed for better code clarity.

withAnimation {
-    viewModel.sendViewState = .reviewPayment
    if viewModel.amountSat == 0 {
        viewModel.sendViewState = .manualEntry
    } else {
        viewModel.sendViewState = .reviewPayment
    }
}

---

93-100: Remove redundant assignment in pasteAddress function.

Similar to the handleScan function, there's a redundant assignment on line 94 that sets viewModel.sendViewState = .reviewPayment just before the conditional block that sets it again. This initial assignment can be safely removed.

withAnimation {
-    viewModel.sendViewState = .reviewPayment
    if viewModel.amountSat == 0 {
        viewModel.sendViewState = .manualEntry
    } else {
        viewModel.sendViewState = .reviewPayment
    }
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a924828 and 254fc70.

📒 Files selected for processing (1)

• LDKNodeMonday/View/Home/Send/SendScanAddressView.swift (1 hunks)

🔇 Additional comments (1)

LDKNodeMonday/View/Home/Send/SendScanAddressView.swift (1)

95-99: Good fix for the zero amount issue.

This change correctly implements the solution for issue #174. Now when a valid address is pasted but the amount is zero, the user will be directed to the manual entry screen instead of the review payment screen. This improves the user experience by allowing them to input an amount while preserving the pasted address.

[reez]

ACK

[danielnordh]

Closes #174