Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add support all profile property types #95

Merged
merged 9 commits into from
Dec 28, 2024

Conversation

comfrt1k
Copy link
Contributor

@comfrt1k comfrt1k commented Dec 25, 2024

Изменила тип на Any для поддержки всех типов, а не только String
Потестила разные типы, включая массивы и JsonObject

Пруфы на скринах ниже

image
image

@comfrt1k comfrt1k requested a review from looee1q December 25, 2024 17:46
@comfrt1k comfrt1k self-assigned this Dec 25, 2024
@looee1q
Copy link
Contributor

looee1q commented Dec 26, 2024

Коммит посмотрел. Пока мне в целом непонятна идея, поэтому задал свой вопрос в соответствующей issue:

Свое мнение по коммиту смогу вынести после ответа на этот вопрос

@looee1q looee1q requested a review from TorinAsakura December 28, 2024 07:40
@TorinAsakura TorinAsakura merged commit b3f7243 into master Dec 28, 2024
1 check passed
@TorinAsakura TorinAsakura deleted the feat/add-support-all-profile-property-types branch December 28, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants