Feat/exclude merchants from search #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
comfrt1k
commented
Dec 20, 2024
comfrt1k
commented
- https://github.com/rees46/development/issues/2162
TorinAsakura
requested review from
looee1q
and removed request for
TorinAsakura
|
В задании сказано:
У тебя функциональность реализована только для intant__search. Нужно добавить и для full_search. Хотя на скрине есть логи и для full_search. Может не хватает коммита? P.S. Отмена замечания. Я поторопился, все норм. |
looee1q
reviewed
Dec 23, 2024
personalization-sdk/src/main/kotlin/com/personalization/api/managers/SearchManager.kt
Outdated
Show resolved
Hide resolved
...k/src/main/kotlin/com/personalization/sdk/data/repositories/network/NetworkRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
...nalization-sdk/src/main/kotlin/com/personalization/features/search/impl/SearchManagerImpl.kt
Outdated
Show resolved
Hide resolved
...nalization-sdk/src/main/kotlin/com/personalization/features/search/impl/SearchManagerImpl.kt
Outdated
Show resolved
Hide resolved
looee1q
approved these changes
Dec 23, 2024
TorinAsakura
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.