-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
<PrivateSet>
#9303
Merged
Merged
<PrivateSet>
#9303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
force-pushed
the
tobbe-privateset
branch
from
October 15, 2023 20:52
021994d
to
211f576
Compare
Tobbe
added
release:fix
This PR is a fix
release:feature
This PR introduces a new feature
and removed
release:fix
This PR is a fix
labels
Oct 15, 2023
dac09
reviewed
Oct 17, 2023
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Oct 19, 2023
…redwood into fix/fe-server-dont-always-timeout * 'fix/fe-server-dont-always-timeout' of github.com:dac09/redwood: `<PrivateSet>` (redwoodjs#9303)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
<Private>
component and theprivate
prop on<Set>
. Instead we introduce a new<PrivateSet>
component.This PR should be fully backwards compatible.
Fully removing
<Private>
andprivate
will be done in RW v7 (or later major version)See also: #9271
Fixes #2562
Fixes #9304
Also fixes the issue addressed by #9306