Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<PrivateSet> #9303

Merged
merged 12 commits into from
Oct 18, 2023
Merged

<PrivateSet> #9303

merged 12 commits into from
Oct 18, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Oct 15, 2023

Deprecate the <Private> component and the private prop on <Set>. Instead we introduce a new <PrivateSet> component.

This PR should be fully backwards compatible.
Fully removing <Private> and private will be done in RW v7 (or later major version)

See also: #9271

Fixes #2562
Fixes #9304

Also fixes the issue addressed by #9306

@Tobbe Tobbe added release:fix This PR is a fix release:feature This PR introduces a new feature and removed release:fix This PR is a fix labels Oct 15, 2023
@Tobbe Tobbe added this to the next-release milestone Oct 15, 2023
@Tobbe Tobbe enabled auto-merge (squash) October 18, 2023 05:38
@Tobbe Tobbe merged commit fca02b6 into redwoodjs:main Oct 18, 2023
30 checks passed
@Tobbe Tobbe deleted the tobbe-privateset branch October 18, 2023 06:48
dac09 added a commit to dac09/redwood that referenced this pull request Oct 19, 2023
…redwood into fix/fe-server-dont-always-timeout

* 'fix/fe-server-dont-always-timeout' of github.com:dac09/redwood:
  `<PrivateSet>` (redwoodjs#9303)
jtoar pushed a commit that referenced this pull request Nov 2, 2023
@jtoar jtoar modified the milestones: next-release, v6.4.0 Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
3 participants