Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(fw): Adds super:clean command #8749

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

dac09
Copy link
Contributor

@dac09 dac09 commented Jun 27, 2023

Suggested by @cannikin, if we use it often enough might as well have it here.

@dac09 dac09 added the release:chore This PR is a chore (means nothing for users) label Jun 27, 2023
@dac09 dac09 requested a review from cannikin June 27, 2023 08:40
@cannikin
Copy link
Member

HA Do we want to add a super namespace? I was thinking like build:super-clean or build:megaclean. Is it annoying to have a dash in the name? Maybe a flag instead? Like build:clean --git to hint that it's going git clean as well? git clean can be dangerous, should we have a confirmation of what it's going to do before actually running it?

Or am I overthinking it? haha

@dthyresson
Copy link
Contributor

Or am I overthinking it? haha

I needed this command again this morning and came here to remember it.

How about:

build:clean:super

because it's building cleanly but superbly.

@cannikin
Copy link
Member

cannikin commented Jul 3, 2023

Ooo I like that, what do you think @dac09 ? It’s nested under clean so it’s clear it’s a subcommand (that actually does more!)

@dac09
Copy link
Contributor Author

dac09 commented Jul 3, 2023

Ooo I like that, what do you think @dac09 ? It’s nested under clean so it’s clear it’s a subcommand (that actually does more!)

Yep seems reasonable to me :)

@cannikin cannikin added this to the next-release milestone Jul 3, 2023
@dac09 dac09 enabled auto-merge (squash) July 3, 2023 17:29
@dac09 dac09 merged commit 589e87a into redwoodjs:main Jul 3, 2023
@jtoar jtoar modified the milestones: next-release, chore Jul 4, 2023
@Josh-Walker-GM Josh-Walker-GM modified the milestones: chore, v8.0.0 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants