Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cells]: Show Success if there's any data in any of the fields #7704

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Feb 28, 2023

Fixes #7538.

Please note that the codemod is just a work in progress and probably won't ship the way it is. It works when I've tired it locally on a project, but needs tests, and more importantly, to not just copy from @redwoodjs/internal.

I can't remember the exact details of why we don't import from @redwoodjs/internal in the codemods package. It probably had to do with the size of the package, and maybe something with circular dependencies. It's been a while since, so maybe it's ok now and just needs a revisiting.

@jtoar jtoar added the release:breaking This PR is a breaking change label Feb 28, 2023
@replay-io
Copy link

replay-io bot commented Mar 1, 2023

16 replays were recorded for 41e89e6.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/47ccadab-537c-4364-b9e5-18ae9271a6c2>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/691bf78d-3412-4614-b2d1-a5fe72af39e5>Check that <meta> tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/b4d488dd-d9e5-4377-b263-a6343ce4de4e>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/00ebc186-24e4-4a10-be21-ada63577257c>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/b6598d42-b770-419d-8d05-aa0c67d1c718>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/66fe39d5-d12a-4aab-af6b-ac07819bced5>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/20806611-b815-4887-9a1a-5240f0a47646>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/aa493afc-5744-4338-803d-412ef559e819>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/25986a38-3f7c-4bf1-a2be-95e8f150ef9b>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/2f4bdf8a-9edc-40ee-a71f-6143f47e4335>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/98b26cd0-b7d3-4b5e-906e-5dcf368e8fb8>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/177c2a9c-12ff-4d5f-9ee7-12ed420a505a>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/3e353f71-c84f-4913-9442-e59faf00d61e>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/fdb020da-9473-455c-9770-f5233cba5d66>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/35216c28-d436-432c-aa63-1d69678e25c5>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@jtoar jtoar marked this pull request as ready for review March 1, 2023 22:43
@jtoar
Copy link
Contributor Author

jtoar commented Mar 1, 2023

Talked with @thedavidprice earlier and he doesn't want to spend time trying to get internal working with codemods. So, just going with the copy-into-lib strategy again. Plus @Josh-Walker-GM needs the cell functions for the other cell codemod.

@jtoar jtoar force-pushed the ds-fix-cell-empty-behavior branch from 777f7a9 to 04e4d5f Compare March 2, 2023 01:37
@jtoar jtoar force-pushed the ds-fix-cell-empty-behavior branch from 86c2b9d to 41e89e6 Compare March 2, 2023 01:50
@jtoar jtoar merged commit 28bdd73 into main Mar 2, 2023
@jtoar jtoar deleted the ds-fix-cell-empty-behavior branch March 2, 2023 02:41
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone Mar 2, 2023
dac09 added a commit to dac09/redwood that referenced this pull request Mar 7, 2023
* 'main' of github.com:redwoodjs/redwood: (50 commits)
  Use formatCacheKey() when deleting a key (redwoodjs#7362)
  fix(deps): update dependency @types/node to v16.18.14 (redwoodjs#7739)
  chore(deps): update dependency @npmcli/arborist to v6.2.4 (redwoodjs#7741)
  chore(deps): update dependency @replayio/playwright to v0.3.24 (redwoodjs#7738)
  chore(deps): update dependency @testing-library/react to v14 (redwoodjs#7737)
  chore(deps): update dependency @testing-library/dom to v9 (redwoodjs#7736)
  chore(deps): update dependency @types/vscode to v1.76.0 (redwoodjs#7729)
  chore(deps): update dependency zx to v7.2.0 (redwoodjs#7731)
  fix(deps): update dependency webpack-bundle-analyzer to v4.8.0 (redwoodjs#7735)
  fix(deps): update dependency babel-plugin-polyfill-corejs3 to v0.7.1 (redwoodjs#7732)
  fix(deps): update dependency msw to v1.1.0 (redwoodjs#7733)
  chore(deps): update dependency @clerk/clerk-react to v4.12.0 (redwoodjs#7728)
  fix(deps): update dependency @types/node to v16.18.13 (redwoodjs#7727)
  fix: change isDataEmpty, add codemod, fix codemod (redwoodjs#7704)
  fix: avoid naming conflict with `client` prop (redwoodjs#7024)
  fix(deps): update jest monorepo to v29.4.3 (redwoodjs#7651)
  chore(deps): update dependency @auth0/auth0-spa-js to v2 (redwoodjs#7524)
  fix(deps): update dependency @types/aws-lambda to v8.10.111 (redwoodjs#7726)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.7.7 (redwoodjs#7725)
  chore(deps): update dependency supertokens-node to v13.1.2 (redwoodjs#7714)
  ...
@jtoar jtoar modified the milestones: next-release, v5.0.0 Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:breaking This PR is a breaking change
Projects
None yet
1 participant