Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react): upgrade React typings to use a more explicit children prop declaration #6320

Merged
merged 6 commits into from
Sep 14, 2022
Merged

chore(react): upgrade React typings to use a more explicit children prop declaration #6320

merged 6 commits into from
Sep 14, 2022

Commits on Sep 13, 2022

  1. fix(react): add PropsWithChildren 

    https://solverfox.dev/writing/no-implicit-children/
    @virtuoushub
    virtuoushub committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    6435b4a View commit details
    Browse the repository at this point in the history

  2. chore: fix for diff between React 17/18's PropsWithChildren

    @virtuoushub
    virtuoushub committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    1d9c36c View commit details
    Browse the repository at this point in the history

  3. chore(react@18): type children explicitly 

    see:
- https://stackoverflow.com/a/71809927/88106
- redwoodjs#6320 (comment)
- redwoodjs#6320 (comment)
    @virtuoushub
    virtuoushub committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    072e8c7 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. chore: remove intersection type 

     favor explicit declarations over intersection type


see: https://github.com/redwoodjs/redwood/pull/6320/files#r970341633
    @virtuoushub
    virtuoushub authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    408541b View commit details
    Browse the repository at this point in the history

  2. style: whitespace 

    manually edited in GitHub and formater/linter didn't kick in
    @virtuoushub
    virtuoushub authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    12fb531 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into chore/upgrade-react-typings

    @Tobbe
    Tobbe authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    23852e3 View commit details
    Browse the repository at this point in the history