chore(lint, workspace): Orderliness and break avoiding lint rules, package.json flags

[Krisztiaan]

import/order: group and order imports to make imports easily scannable and deterministic
no-restricted-imports: warn about using src/* because typescript does not replace these paths so the imports will be any in the d.ts files

PARTIALLY Closes #1297

[Krisztiaan]

Something like typescript-transform-paths could also be used to avoid needing the src/* rule though.

[peterp]

Something like typescript-transform-paths could also be used to avoid needing the src/* rule though.

Oooh, that's really cool - I really like the src/ alias, could we try this out?

[Krisztiaan]

src is success, made some tuning on the import order, and extracted the eslint config from package.json. Moved scripts in package.json to start of file, as it's one of the most important things to overview when opening that file.

Added ttsc (not a typo!) that provides plugin capabilities to the typescript compiler. Needed for the src/* mapping.

[peterp]

Hey @Krisztiaan, I would love to get this merged, I've finally reviewed everything!

I tried to fix the merge conflicts, but I can't seem to get the tests to complete on my end. They're stalling infinitely.

[peterp]

Ah, I see the same tests are failing in the previous tests.

[peterp]

Damnit, I would love to merge this.

[github-actions]

📦 Packages for this PR can be downloaded from
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/create-redwood-app-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-api-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-api-server-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-auth-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-cli-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-core-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-dev-server-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-eslint-config-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-eslint-plugin-redwood-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-forms-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-internal-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-router-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-structure-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-testing-0.21.0-081beff.tgz
https://rw-pr-redwoodjs-com.s3.amazonaws.com/1381/redwoodjs-web-0.21.0-081beff.tgz

Install locally with yarn, e.g. yarn workspace web add <url>

[peterp]

LGTM!

[AntonioMeireles]

late to the party, (sorry) - is there any good reason for the rules that were inside .eslintrc not to be in plain stock eslint-config so that rw projects would also consume them out of the box ?

[Krisztiaan]

@AntonioMeireles probably me misunderstanding this

[AntonioMeireles]

@Krisztiaan

actually you didn't 😄 - at the time it made sense. it's just that the 'no-restricted-imports'that was the culprit ended going away and the remaining bits imho are idiomatic and generic enough that they could just be shipped in eslint-config.

[Krisztiaan]

That's what I mean by misunderstanding, I moved everything to project level instead of just the src rule