Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rsc): Simplify RscRoutes by removing external promise #11574

Merged
merged 1 commit into from
Sep 17, 2024
Merged

chore(rsc): Simplify RscRoutes by removing external promise #11574

merged 1 commit into from
Sep 17, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Sep 17, 2024

I figured out how I could do things without the need for the external promise I had before. This simplifies the code a lot

@Tobbe Tobbe added release:chore This PR is a chore (means nothing for users) experimental This PR relates to only experimental feature(s) labels Sep 17, 2024
@Tobbe Tobbe added this to the chore milestone Sep 17, 2024
@Tobbe Tobbe added the fixture-ok Override the test project fixture check label Sep 17, 2024
@Tobbe Tobbe merged commit 4972f4a into redwoodjs:main Sep 17, 2024
58 of 61 checks passed
@Tobbe Tobbe deleted the tobbe-rsc-no-external-promise branch September 17, 2024 11:58
Josh-Walker-GM pushed a commit that referenced this pull request Sep 19, 2024
@Tobbe @Josh-Walker-GM
chore(rsc): Simplify RscRoutes by removing external promise (#11574)
2c25d79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
experimental This PR relates to only experimental feature(s) fixture-ok Override the test project fixture check release:chore This PR is a chore (means nothing for users)
Projects
None yet
Milestone
chore
Development

Successfully merging this pull request may close these issues.
1 participant
@Tobbe