Infer correct state when input selectors are a mix of explicit and rest syntax in createSelector #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state parameter of the result of createSelector was of type never if input selectors were a mix of explicit and spread selectors
Previous test implies that different input state types are not supported in inference, only the state of the first selector is picked. Advanced tests for different input states in selectors therefore have to be removed since typescript v4.6 and before does not support it. Additionally, parameter is added to test, to test that the parameter is included in the output selector paraemeters.
…d rest syntax This makes sure that extra parameters from input selectors are not lost when using a combination of explicit parameters and rest syntax.
PeterBul
commented
Mar 16, 2023
| type UnknownFunction = (...args: any[]) => any | ||
|
|
||
| type LongestTuple<T extends readonly unknown[][]> = T extends [ |
There was a problem hiding this comment.
The readonly unknown[][] requirement has to be removed from several places since ReverseHead and ReverseTail use recursive types to find the first an last tuple element. Typescript complains when a condition (like readonly unknown[][]) has to to be compared with a type that is recursive, since it can't check the result of that type.
The checks of whether a type is readonly unknown[][] are moved to conditintional types instead where it is needed.
These are internal types specifically used for this use case, so removing the requirement should not be an issue.
PeterBul
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state parameter of the result of createSelector was of type never if input selectors were a mix of explicit and spread selectors. Additionally, the type of extra parameters are lost if the input has this format.
This PR aims to allow the combining of explicitly defined input selectors and using rest syntax in the end. It does so by making sure that the type of the array that is part of the rest syntax is transformed into a normal type before merging the parameter tuples. This is valid since we really don't care whether we have 1 or 10 selectors in the array that is spread as long as the types are the same.
This is related to issue 601 where some more details can be found in the conversation.