Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typings #243

Closed
wants to merge 1 commit into from
Closed

Fixed typings #243

wants to merge 1 commit into from

Conversation

rikkertkoppes
Copy link

This does not compile

export type Selector<S, R> = (state: S) => R;
export interface OutputSelector<S, R, C> extends Selector<S, R> {
  resultFunc: C;
  recomputations: () => number;
  resetRecomputations: () => number;
}

interfaces cannot extend types.

https://github.com/reactjs/reselect/blob/master/src/index.d.ts#L3-L8

This does not compile

    export type Selector<S, R> = (state: S) => R;
    export interface OutputSelector<S, R, C> extends Selector<S, R> {
      resultFunc: C;
      recomputations: () => number;
      resetRecomputations: () => number;
    }

interfaces cannot extend types.

https://github.com/reactjs/reselect/blob/master/src/index.d.ts#L3-L8
@coveralls
Copy link

coveralls commented Apr 12, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 4d8aa77 on rikkertkoppes:patch-1 into 5eea93a on reactjs:master.

@codecov-io
Copy link

Codecov Report

Merging #243 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #243   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          15     15           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eea93a...4d8aa77. Read the comment docs.

@aikoven
Copy link
Contributor

aikoven commented Apr 13, 2017

Please see #240

Also, you can switch to TypeScript 2.2 where interfaces extending type aliases is allowed.

@alex3165
Copy link
Contributor

This is fixed by #240 I have just released it with 3.0.1

@alex3165 alex3165 closed this May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants