completely recreate badSelector between tests so firstRun is reset

reduxjs · Dec 1, 2023 · 50a327f · 50a327f
1 parent 75c2250
commit 50a327f
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -29,6 +29,7 @@
     "prepack": "yarn build",
     "bench": "vitest --run bench --mode production",
     "test": "node --expose-gc ./node_modules/vitest/dist/cli-wrapper.js run",
+    "test:watch": "node --expose-gc ./node_modules/vitest/dist/cli-wrapper.js watch",
     "test:cov": "vitest run --coverage",
     "type-check": "vitest --run typecheck",
     "type-check:trace": "vitest --run typecheck && tsc --noEmit -p typescript_test/tsconfig.json --generateTrace trace && npx @typescript/analyze-trace trace && rimraf trace",

diff --git a/test/identityFunctionCheck.test.ts b/test/identityFunctionCheck.test.ts
@@ -5,16 +5,18 @@ import { localTest } from './testUtils'
 describe('identityFunctionCheck', () => {
   const consoleSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
   const identityFunction = vi.fn(<T>(state: T) => state)
-  const badSelector = createSelector(
+  let badSelector = createSelector(
     [(state: RootState) => state],
     identityFunction
   )
 
   afterEach(() => {
     consoleSpy.mockClear()
     identityFunction.mockClear()
-    badSelector.clearCache()
-    badSelector.memoizedResultFunc.clearCache()
+    badSelector = createSelector(
+      [(state: RootState) => state],
+      identityFunction
+    )
   })
   afterAll(() => {
     consoleSpy.mockRestore()
@@ -42,7 +44,7 @@ describe('identityFunctionCheck', () => {
   localTest('includes stack with warning', ({ state }) => {
     expect(badSelector(state)).toBe(state)
 
-    expect(identityFunction).toHaveBeenCalledTimes(1)
+    expect(identityFunction).toHaveBeenCalledTimes(2)
 
     expect(consoleSpy).toHaveBeenCalledWith(
       expect.stringContaining(