use shelljs for shell like commands #94
Conversation
|
Also note that ansi codes currently will not come through on output. |
|
@mikekidder Do you need help fixing those problems? |
If you want to get away from npm script, as you mention in commit, could also look into gulp. |
|
Woah, color support is a bummer! The issue has been up for two years.. Can you help me with understanding what exactly fails on Windows? How are shell scripts different from the same commands right inside |
|
No difference in running npm script vs. shelljs. The test scripts were put in after my initial PR's, and hadn't ran them yet until yesterday. This fixes test:cov as mentioned in gotwarlost/istanbul#90. Path to mocha should work on Mac as well. And looks like test:watch is working. This really leaves no color output as the issue. |
|
Thanks! I'll take another look later today. |
|
|
||
| sh.exec('eslint src test', function(code, output) { | ||
|
|
||
| if(code === 0){ |
There was a problem hiding this comment.
Nit pick: missing space before { and unneeded newlines before and after if block.
|
This PR should also remove the old scripts, right? |
|
Sorry for dragging my feet here. I'm very busy atm, but will be more available in a week or so. Just give me some more time before looking at it! |
|
Oh, no worries from me. I know how to work around the shell scripts. :) |
|
Closing in favor of #267. |
|
Fixed by #267, the fix is merged into |
This is preliminary; unsure of the test:cov and test:watch.. The latter is causing a loop