Have combineReducers return same object if nothing changes #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const initialState = reducer(undefined, '@@INIT'); | ||
| expect(reducer(initialState, { type: 'FOO' })).toBe(initialState); | ||
| }); | ||
|
|
There was a problem hiding this comment.
I'd like to see more tests.
We need to check that:
- With several reducers, having just one return something different is enough to cause inequality
- With several reducers, having all return the same is enough to maintain equality
aaronjensen
force-pushed
the
combine-reducers-reference-equality
branch
from
07dd1b0 to
6b8a4a8
Compare
|
@gaearon I believe I've addressed your feedback, please let me know if there is anything else. Thanks! |
gaearon
added a commit
that referenced
this pull request
Oct 7, 2015
…quality Have combineReducers return same object if nothing changes
|
This is good to go, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #853