-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type-check tests #4489
Type-check tests #4489
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6714d12:
|
0ddeaf7
to
85200df
Compare
85200df
to
a206d04
Compare
Hmm. Apparently the optimization I added / copied that tries to skip tests if there are no While you're at it, can you try tweaking the condition to run if there's changes to Worst case, just kill the condition and always run the tests for now. |
Odd test failure for TypeScript 4.1. I'll take a look later. |
rxjs types only supports >=4.2 👀
|
I think we're good to drop testing against TypeScript 4.1? It came out on 11/19/20 so it's older than the 2-year support window defined by DefinitelyTyped. |
Yep, absolutely! We've generally done rolling TS version compat in our minor releases anyway, so let's drop 4.1 from the test matrix. (Might as well add 5.0-beta while we're at it?) |
✅ Deploy Preview for redux-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
In #4487 we switched from ts-jest (which runs type-checking on test files) to Vitest (which does not).
This PR runs type-checking on the tests to make sure they pass.