Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bracket for comments #3408

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

pingfengafei
Copy link
Contributor

reducer should wrapped with [] just the same as preloadedState and enhancer

@pingfengafei pingfengafei changed the title add bracket for comments Add bracket for comments Apr 18, 2019
@netlify
Copy link

netlify bot commented Apr 18, 2019

Deploy preview for redux-docs ready!

Built with commit dde37e8

https://deploy-preview-3408--redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Apr 18, 2019

Thanks!

@timdorr timdorr merged commit d6bad9a into reduxjs:master Apr 18, 2019
@epeterson320
Copy link

@pingfengafei I don't think it should be wrapped with brackets. That's how you mark a parameter as optional. To create a store, the reducer isn't optional.

http://usejsdoc.org/tags-param.html#optional-parameters-and-default-values

@timdorr
Copy link
Member

timdorr commented May 3, 2019

Oh, I'm not super familiar with JSDoc syntax. I'll revert this.

timdorr added a commit that referenced this pull request May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants