Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iterate using for in instead of Object.keys and minor fixes #3371

Merged
merged 4 commits into from
Mar 9, 2019

Conversation

pvorona
Copy link
Contributor

@pvorona pvorona commented Mar 8, 2019

Even though this code has no impact on the overall performance of the application for in is faster in modern browsers (https://jsperf.com/object-keys-vs-for-in-with-closure/138).
I propose this change only as readability improvement.

@netlify
Copy link

netlify bot commented Mar 8, 2019

Deploy preview for redux-docs ready!

Built with commit 235aa07

https://deploy-preview-3371--redux-docs.netlify.com

@timdorr
Copy link
Member

timdorr commented Mar 9, 2019

Not a huge deal, but why not. Thanks!

@timdorr timdorr merged commit 9c0b741 into reduxjs:master Mar 9, 2019
kiku-jw pushed a commit to kiku-jw/redux that referenced this pull request Apr 6, 2019
…3371)

* Iterate using for in

* Use single quotes for string literals without interpolation

* Fix punctuation.

* Limit node version until we update jest.


Co-authored-by: Tim Dorr <timdorr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants