-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lodash-webpack-plugin. #1699
Conversation
Neat! Been looking forward to this since I saw you posted about it on Twitter. This gets a 👍 from me! |
Oh. My. |
This would introduce a discrepancy between the CommonJS and the UMD builds because CommonJS builds wouldn’t work this way. So adding something like To solve this, we could always bundle to a single file with Webpack, even for CommonJS. I’m not opposed to this, but it’s a breaking change, as we currently semi-support |
The problem is that people use |
They’re not quite private. I remember promising support for this use case some time during 2.x when tools like Rollup or Webpack 2 weren’t yet available, and some libraries that depended on Redux wanted smaller builds. So any top-level file under |
I assume not all CommonJS use is to bundle. Couldn't you defer to the consumer to decide how they wish to bundle things. I mean, they may use webpack or browserify or rollup or uglify or closure-compiler or various other plugins and transforms. If they find size is an issue, they too could use |
Yea sorry, I’ve been busy with other projects and haven’t had a chance to take another look at this.
|
No worries. I'm sure you'll get there. |
I just released lodash-webpack-plugin.
This would ensure you continue to get smaller modular builds and would allow you to expand your Lodash module use without worrying about the overhead of things like iteratee shorthands.