Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1382

Merged
merged 2 commits into from
Feb 11, 2016
Merged

Update README.md #1382

merged 2 commits into from
Feb 11, 2016

Conversation

jbovenschen
Copy link
Contributor

After merging #1339 this project does have a dependency.

I think it is better to remove the "and has no dependencies" from the README.md.
Maybe it would be better to explain why lodash is added as a dependency.

After merging reduxjs#1339 this project does have a dependency.

I think it is better to remove the "and has no dependencies" from the README.md.
Maybe it would be better to explain why lodash is added as a dependency.
@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2016

Yeah, this came up before. Technically it has a dependency but we are talking about two ten-line files, not the whole Lodash. We use just those two modules, and similar code was previously bundled into Redux, so there is no sensible size difference.

Can we reword it in a way that suggests that it’s 2kB including the dependencies? This way we make it clear Lodash doesn’t make the build large.

@jbovenschen
Copy link
Contributor Author

I guess it would be nice to have a sentence something like the following;
It is tiny (2kB) including lodash utilities. ?

Because it makes it more clear that it has just one dependency that is lodash and it is using lodash for providing utility functions from lodash.

@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2016

I don’t want to mention Lodash specifically. That we are using it is an implementation detail nobody should worry or care about.

Maybe like this?

It is tiny, even when bundled with the dependencies (2kB).

@acdlite
Copy link
Collaborator

acdlite commented Feb 10, 2016

It is tiny (2kB, including dependencies).

Perhaps?

@gaearon
Copy link
Contributor

gaearon commented Feb 10, 2016

@acdlite 👍

@jbovenschen
Copy link
Contributor Author

@acdlite I think that one is great i will change it tonight!

gaearon added a commit that referenced this pull request Feb 11, 2016
@gaearon gaearon merged commit 0fc8267 into reduxjs:master Feb 11, 2016
@gaearon
Copy link
Contributor

gaearon commented Feb 11, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants