Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new version of upsert proposal, and fix listener equality checks #4735

Merged
merged 6 commits into from
Nov 28, 2024

Conversation

EskiMojo14
Copy link
Collaborator

Proposal has been simplified to a getOrInsert method - this updates our code accordingly to see what the difference is like.

Copy link

codesandbox bot commented Nov 27, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Nov 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05a8322:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 05a8322
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/6748baf8c3afc40008d55a7f
😎 Deploy Preview https://deploy-preview-4735--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 27, 2024

size-limit report 📦

Path Size
1. entry point: @reduxjs/toolkit/query/react (modern.mjs) 13.53 KB (-0.13% 🔽)
1. entry point: @reduxjs/toolkit (cjs, production.min.cjs) 14.1 KB (-0.51% 🔽)
1. entry point: @reduxjs/toolkit/react (cjs, production.min.cjs) 14.22 KB (-0.46% 🔽)
1. entry point: @reduxjs/toolkit/query (cjs, production.min.cjs) 22.34 KB (-0.24% 🔽)
1. entry point: @reduxjs/toolkit/query/react (cjs, production.min.cjs) 24.39 KB (-0.24% 🔽)
2. entry point: @reduxjs/toolkit (without dependencies) (cjs, production.min.cjs) 7.5 KB (-0.84% 🔽)
2. entry point: @reduxjs/toolkit/query (without dependencies) (cjs, production.min.cjs) 9.21 KB (+0.16% 🔺)
3. createSlice (.modern.mjs) 4.16 KB (-0.96% 🔽)
3. buildCreateSlice and asyncThunkCreator (.modern.mjs) 5 KB (-0.74% 🔽)
3. combineSlices (.modern.mjs) 1.02 KB (-2.97% 🔽)
3. createDynamicMiddleware (.modern.mjs) 839 B (-9.11% 🔽)
3. createDynamicMiddleware (react) (.modern.mjs) 948 B (-7.61% 🔽)
3. createListenerMiddleware (.modern.mjs) 1.98 KB (-1.03% 🔽)
3. createApi (.modern.mjs) 13.92 KB (-0.15% 🔽)
3. createApi (react) (.modern.mjs) 15.65 KB (-0.05% 🔽)

@EskiMojo14 EskiMojo14 marked this pull request as ready for review November 27, 2024 21:36
@EskiMojo14 EskiMojo14 changed the title Update to new version of upsert proposal Update to new version of upsert proposal, and fix listener equality checks Nov 28, 2024
@markerikson markerikson merged commit fdfc3b7 into master Nov 28, 2024
74 checks passed
@markerikson markerikson deleted the upsert-new branch November 28, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants