-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oazapfts to 6.0.2 #4198
Update oazapfts to 6.0.2 #4198
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7939056:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes were necessary to fix errors regarding the new import structure that does not seem to work (for TypeScript at least), s. this workflow run. I am not fully aware of the implications this might have for building and packaging, so please take a closer look.
fee02e2
to
a28a890
Compare
Any update to this? Definitely would love to have the updates to oazapfts :) |
f1ec95c
to
7939056
Compare
I am trying to keep this PR up to date with @markerikson, you have responded in the corresponding issue a while ago. Any chance you could look into this PR any time soon? I'd be glad to rework anything that prevents this PR from being merged. |
I'm currently working on a project that could use this update! I'm happy to contribute if needed. By the way, |
@yamilelias , @SimonEggert : yeah, apologize for the complete delay and falling through the cracks on this one. There's been a couple factors. Lenz did all the initial work on the codegen, but hasn't had much time for Redux maintenance over the last year. I've been busy with personal life and all my Redux-related time this year has gone to trying to update our tutorial (and frankly also tried to filter out all codegen related discussion because I haven't worked on it and I don't have the brain space to think about it). Skimming this, it seems reasonable at first glance. I'll go ahead and merge this and then figure out how to get this published! |
Drat. Tried to publish it and ran into some kind of an NPM-related issue. I don't have time to investigate this now, but I will try to look at it as soon as i have time. (Realistically that may not be until Sunday or early next week.) |
@markerikson code-gen was deployed 9 months ago, so probably it's still on your todo list? :) |
Should be live in https://github.com/reduxjs/redux-toolkit/releases/tag/%40rtk-query%2Fcodegen-openapi%402.0.0-alpha.0 ! Please try it out and let us know if it works. |
Works like a charm. On my end, types are greatly improved. Schema definitions like: { "YourApi": { "properties": { "someParam": { "type": ["null", "string"] } } } } are now correctly typed as: type YourApiArg = { someParam: null | string } instead of Thank you 🙏🏾 |
Some issues (s. #3814) have been fixed in upstream library
oazapfts
so this is an attempt to update it to the latest version.The major updates that this update has stepped over are mainly regarding changes to exported files that have been addressed by this PR.
oazapfts
now includes comments in the generated types, so I also needed to update the snapshot tests.closes #3814