-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade version of "graphql-request" #3488
Upgrade version of "graphql-request" #3488
Conversation
Upgrading the version of "graphql-request" to use the latest. This is not only to get onto the latest version of the package, but also to remove an internal bug to that can surface from it. In this case, there are duplicate `AbortSignal` types, one defined by the Typescript language, and one defined by the package. This update removes this conflict.
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview |
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59f0720:
|
Can we merge this? |
@markerikson would it be possible for you to merge this PR? It looks like you approved of the idea in the linked issue: |
@markerikson Hi Mark, can this PR be merged? It should resolve the linked issue: |
@donovan-ecargo Any chance we could also update the redux toolkit peer dependency while we're at it? With the release of RTK 2.0 this causes a dependency issue when installing:
If not, we could allow this in a separate PR. Thanks. |
Damn, this sat open for far too long - unfortunately, I can't push any modifications to this branch and there are some slight modifications needed, so I'll have to do this on our side - reopening in #4026 I'll republish with a better peerDependency after. |
released as @rtk-query/graphql-request-base-query@2.3.0 |
Upgrading the version of "graphql-request" to use the latest. This should help ensure the latest is in use, with all the bug fixes that come with it. Notably a fix for a typing conflict for
AbortSignal
.I've requested if it was okay to update the package, but if there's a preference to open an issue more specific to updating the package, I'll happily open one.
Related issue where I asked for permission:
#2931