Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement codemods for createReducer and createSlice builder #2303

Closed
wants to merge 1 commit into from

Conversation

martinerko
Copy link
Contributor

ref #2301

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60b154d:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration

@phryneas
Copy link
Member

phryneas commented Jul 3, 2022

Thanks! Could you please move this to a separate folder packages/codemods?

@markerikson
Copy link
Collaborator

@martinerko do you have time to move these files and update the PR, or should we handle it?

@martinerko
Copy link
Contributor Author

martinerko commented Aug 15, 2022

@martinerko do you have time to move these files and update the PR, or should we handle it?

Sorry I have been extremely busy last couple of weeks and I am afraid I will not have enough time untill end of this month. I am happy to look into it early September if that helps

@markerikson
Copy link
Collaborator

@martinerko no problem - I'll take care of updating this PR so we can get these published alongside 1.9 when it's ready (hopefully soon-ish!)

Thanks for putting this together!

@markerikson markerikson added this to the 1.9 milestone Aug 16, 2022
@markerikson
Copy link
Collaborator

Looks like the commit was done directly on your fork's master branch, so I can't push my changes up.

Given that, I'm going to close this PR, cherry-pick the commit into a new branch myself, and push and merge that.

Thank you for putting these together!

@markerikson
Copy link
Collaborator

Ported to #2602 , moved them to a new packages/rtk-codemods folder and added a placeholder package.json. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants