-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect BaseQuery meta types when enhancing #2225
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c392575:
|
✅ Deploy Preview for redux-starter-kit-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Could somebody enable CI and review, please? @phryneas ? |
Sorry, this somehow slipped by. Thanks for the ping! |
@phryneas bump |
Sorry, lots of real life going on :) Taking a look at this now 👀 |
Actually... please can you provide a CodeSandbox that demonstrates the issue at hand, or maybe even add some type tests that show the intended behaviour? Your description is very short and I'm not 100% sure where exactly |
@phryneas Sure, added type tests, hope it makes things clear. What still wouldn't work is to inline |
Now it's super clear - thank you for the PR! |
Fixes #2224
As an alternative, the
BaseQueryMeta<…>
itself could remove the undefined, I don't see any risk in doing so. Let me know what you thinkAPI Report File for "@reduxjs/toolkit"