Fix addMatcher typings

[crcarrick]

References #1861

Previously, the action argument passed down to the reducer function of addMatcher(matcher, reducer) would be incorrectly typed as AnyAction when the type predicate being tested by the matcher function didn't include a type property.

This PR attempts to resolve the issue:

• Widens the type argument of ActionMatcher from A extends AnyAction to A.
• Maintains the previous behavior of defaulting the type of the action argument to AnyAction when there is no type predicate.
• Intersects the A type argument with AnyAction to satisfy the second type argument to CaseReducer and offer better completion inside the reducer function.
• Adds a type test to the mapBuilders.typetest.ts file that verifies that the action argument is now correctly typed.

"If you changed external-facing types, make sure to also build the project locally and include the updated API report file etc/redux-toolkit.api.md in your pull request."

I was unable to accomplish this. I ran the monorepo build script and the @reduxjs/toolkit build scripts but this file was never updated. All of the build:* scripts in the @reduxjs/toolkit workspace's package.json file include the --skipExtraction flag which seems like it would prevent the extraction tool from running. addMatcher() and ActionMatcher are referenced in the etc/redux-toolkit.api.md file, so I think the file should be updated with this PR. If somebody could point me in the right direction on how to get the tooling to do that, I would be grateful.

Thanks for taking the time to look at this and let me know what you all think!

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1a3231:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration
rsk-github-issues-example	Configuration
reduxjs/redux-toolkit	Configuration
@examples-query-react/advanced	Configuration
@examples-action-listener/counter	Configuration

[netlify]

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: e1a3231

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61eac4b909d3a80007e36694

😎 Browse the preview: https://deploy-preview-1895--redux-starter-kit-docs.netlify.app

[msutkowski]

References #1861

Previously, the action argument passed down to the reducer function of addMatcher(matcher, reducer) would be incorrectly typed as AnyAction when the type predicate being tested by the matcher function didn't include a type property.

This PR attempts to resolve the issue:

• Widens the type argument of ActionMatcher from A extends AnyAction to A.
• Maintains the previous behavior of defaulting the type of the action argument to AnyAction when there is no type predicate.
• Intersects the A type argument with AnyAction to satisfy the second type argument to CaseReducer and offer better completion inside the reducer function.
• Adds a type test to the mapBuilders.typetest.ts file that verifies that the action argument is now correctly typed.

"If you changed external-facing types, make sure to also build the project locally and include the updated API report file etc/redux-toolkit.api.md in your pull request."

I was unable to accomplish this. I ran the monorepo build script and the @reduxjs/toolkit build scripts but this file was never updated. All of the build:* scripts in the @reduxjs/toolkit workspace's package.json file include the --skipExtraction flag which seems like it would prevent the extraction tool from running. addMatcher() and ActionMatcher are referenced in the etc/redux-toolkit.api.md file, so I think the file should be updated with this PR. If somebody could point me in the right direction on how to get the tooling to do that, I would be grateful.

Thanks for taking the time to look at this and let me know what you all think!

@crcarrick Ah... this isn't obvious at all, but you should just be able to run node scripts/cli.js --local (inside of packages/toolkit) to achieve this. We can revisit the package scripts + docs for this separately.

[phryneas]

Tbh., I'm not even sure if the extraction step still works or if the CI actually uses it.

I've used this PR to add some minor refactoring (introducing a new TypeGuard type for this) and I've added a few more type assertions in the tests. Generally, this looks good for me.

[phryneas]

Released in https://github.com/reduxjs/redux-toolkit/releases/tag/v1.7.2