Fix #1853 - updateMany on sorted entity adapter
#1860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fdc845d:
|
|
✔️ Deploy Preview for redux-starter-kit-docs ready! 🔨 Explore the source changes: fdc845d 🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/61c27405e307390008381422 😎 Browse the preview: https://deploy-preview-1860--redux-starter-kit-docs.netlify.app |
|
Yeah, this is a lower-priority fix given that there are workarounds in userland (ie, combine all your own updates first). No rush - I'd like to take this chance to consolidate this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1853.
@markerikson stated that the preferred outcome would be to combine the sorted and unsorted logic into a single implementation, but I haven't done that yet.
So, feel free to merge this PR as is and I can combine the sorted/unsorted logic later, or let me know if you just want to wait until I do the combining in this PR. In either case I probably won't get to that until after the holidays.