Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where the global RTK object got overwritten in the UMD files #1763

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

Antignote
Copy link
Contributor

fix #1761 where the global variable RTK gets overwritten by the other entries in the UMD build

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 23, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2bdcd52:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration

packages/toolkit/scripts/build.ts Outdated Show resolved Hide resolved
packages/toolkit/scripts/build.ts Outdated Show resolved Hide resolved
  use the same namespace for both rtk-query and rtk-query-react since users should only be loading one or the other
  fix reduxjs#1761
@Antignote Antignote force-pushed the feature/umd_unique_namespace branch from e85c10e to 2bdcd52 Compare November 24, 2021 19:22
@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: e85c10e

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/619e908af0a4cc00078ec3d5

😎 Browse the preview: https://deploy-preview-1763--redux-starter-kit-docs.netlify.app

@netlify
Copy link

netlify bot commented Nov 24, 2021

✔️ Deploy Preview for redux-starter-kit-docs ready!

🔨 Explore the source changes: 2bdcd52

🔍 Inspect the deploy log: https://app.netlify.com/sites/redux-starter-kit-docs/deploys/619e910f99b73900074c52d9

😎 Browse the preview: https://deploy-preview-1763--redux-starter-kit-docs.netlify.app

@markerikson markerikson changed the base branch from master to v1.7.0-integration November 26, 2021 19:17
@markerikson markerikson changed the base branch from v1.7.0-integration to master November 26, 2021 19:17
@markerikson markerikson merged commit 8feda19 into reduxjs:master Nov 26, 2021
@markerikson
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React umd files under dist overwrites each other
2 participants