refactor typings for readability #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for redux-starter-kit-docs ready! Built with commit 93509ee https://deploy-preview-168--redux-starter-kit-docs.netlify.com |
phryneas
commented
Aug 3, 2019
|
|
||
| export type ActionCreatorWithPayload<P, T extends string = string> = | ||
| WithTypeProperty<T, <PT extends P>(payload: PT) => PayloadAction<PT, T>>; | ||
|
|
||
| /** | ||
| * An action creator that produces actions with a `payload` attribute. | ||
| */ | ||
| export type PayloadActionCreator< | ||
| P = any, |
There was a problem hiding this comment.
I could go and rename P to payload, T to Type and PA to PrepareActionFn here, but I'm not really sure if it makes things better or worse in the usages of these below.
Do you have an opinion there?
|
@markerikson what's your status on this? From my side this would be ready if you don't have any additional comments. |
|
I'm focusing on trying to finish the tutorials atm. Once I'm done with those, I plan to swing around and start pushing issues and PRs towards 1.0. |
|
Okay :) Just wanted to make sure this didn't get buried ^^ |
|
Sure, let's do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the typings more readable for someone just diving into this lib's typings, as we already discussed on twitter :)